Deployed 114 - Simple OETH Harvester.

[clement-ux]

Dependencies

• Simple harvester for OETH #2333

Deployment

Deploy scripts:
114_simple_harvester.js

Contracts

Contract	Address
OETHHaversterSimple	0x399B69Bf06CCec7A53Befea14771059d39a3617a

Governance

• Proposal id: 24744476590264145931226505760829226060179710806211802903308139275399713774496
• Proposal Tx: 0x16958806e41075851399a239073b2288ebb4fe2a9ddc22841453a17b81576142
• Proposal Payload

[
  [
    "0x1827F9eA98E0bf96550b2FC20F7233277FcD7E63"
  ],
  [
    {
      "type": "BigNumber",
      "hex": "0x00"
    }
  ],
  [
    "setHarvesterAddress(address)"
  ],
  [
    "0x000000000000000000000000399b69bf06ccec7a53befea14771059d39a3617a"
  ]
]

0xda95691a00000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000000010000000000000000000000001827f9ea98e0bf96550b2fc20f7233277fcd7e630000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001c7365744861727665737465724164647265737328616464726573732900000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000020000000000000000000000000399b69bf06ccec7a53befea14771059d39a3617a000000000000000000000000000000000000000000000000000000000000001c4368616e67652068617276657374657220696e204f45544820414d4f00000000

Note: I've messed up with the last commit message, I forgot to change it.

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.84%. Comparing base (a559741) to head (36f1f2d).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
- Coverage   52.59%   51.84%   -0.76%     
==========================================
  Files          80       81       +1     
  Lines        4101     4126      +25     
  Branches     1079     1084       +5     
==========================================
- Hits         2157     2139      -18     
- Misses       1941     1984      +43     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shahthepro]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
  • 🟡 setSupportedStrategy isn't part of the governance proposal but it's fine since the 2/8 can also do it anytime
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

Diff check

Compared the "undefined" file for the "OETHHarvesterSimple" contract with address 0x399B69Bf06CCec7A53Befea14771059d39a3617a on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/governance/Strategizable.sol
match   contracts/harvest/OETHHarvesterSimple.sol
match   contracts/interfaces/IStrategy.sol

[sparrowDom]

• All deployed contracts are listed in the deploy PR's description
• Deployed contract's verified code (and all dependencies) match the code in master
• Contract constructors have correct arguments
• The transactions that interacted with the newly deployed contract match the deploy script.
• Governance proposal matches the deploy script
• Smoke tests pass after fork test execution of the governance proposal

Contract diff

Compared the "OETHHarvesterSimple" contract with address 0x399B69Bf06CCec7A53Befea14771059d39a3617a on mainnet
to local files under folders ".,node_modules"

match   @openzeppelin/contracts/token/ERC20/IERC20.sol
match   @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match   @openzeppelin/contracts/utils/Address.sol
match   contracts/governance/Governable.sol
match   contracts/governance/Strategizable.sol
match   contracts/harvest/OETHHarvesterSimple.sol
match   contracts/interfaces/IStrategy.sol