💥 Refactor invariant setup. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
changed the title
naddison36
approved these changes
Dec 16, 2024
naddison36
added a commit
that referenced
this pull request
Jan 20, 2025
* Fix setFee when changing from a zero performance fee * 💥 Refactor invariant setup. (#55) * Track the Lido withdrawal request amounts * Fixed fork tests with new cross price * Fix config of gas reports * Format code * 💥 Refactor invariant setup. * ✨ Add swap invariants. * ✨ Add extra invariant. * ✨ Add `afterInvariant` logic. * 🐛 Fix not up-only shares. * ⚗️ Push PoC. * 🔥 Remove old code. * ⚡ Adjust invariant error tolerance. * 💚 Fix CI. --------- Co-authored-by: Nicholas Addison <[email protected]> --------- Co-authored-by: Clément <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the invariant setup.
In PR #29, the concept of custom-distribution probability (CDP) was initially introduced but will be reverted to the traditional approach.
The primary reason for this change is to simplify debugging. The CDP method bypassed certain behaviors of the fuzzer, which disrupted key features such as shrinking and maintaining clear debugging traces.