Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle donation attack of Lido withdrawal NFTs #52

Closed
wants to merge 1 commit into from

Conversation

naddison36
Copy link
Collaborator

Changes

  • Someone can temporarily freeze withdrawals from the Lido queue by transferring a Lido withdrawal NFT and then claiming it via the Lido ARM. As the withdrawal request was not done through the Lido ARM, the lidoWithdrawalQueue amount will be smaller than the ETH received by the claim process. This will cause and underflow if all withdrawal requests are claimed.
  • The avoid underflows, lidoWithdrawalQueue is set to zero if its going to underflow.

@naddison36
Copy link
Collaborator Author

Closing for an alternative approach of storing the withdrawal request amount so any Lido mass slashing events can be better socialised to LP holders.

@naddison36 naddison36 closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant