Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas saving when claiming Lido withdrawals #50

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Gas saving when claiming Lido withdrawals #50

merged 7 commits into from
Dec 16, 2024

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Nov 25, 2024 •
edited
Loading

  • Moved calculating the Lido claim withdrawal hints off-chain when calling claimLidoWithdrawals

Before

| Function Name                                                       | min             | avg    | median | max     | # calls |
| claimLidoWithdrawals                                                | 20456           | 36554  | 37265  | 52297   | 10      |

After

| Function Name                                                       | min             | avg    | median | max     | # calls |
| claimLidoWithdrawals                                                | 15983           | 27233  | 28897  | 39693   | 10      |

clement-ux
clement-ux approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@naddison36 naddison36 merged commit e05ecf2 into main Dec 16, 2024
2 checks passed
@naddison36 naddison36 deleted the nicka/claim-lido-withdrawals branch December 16, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clement-ux clement-ux clement-ux approved these changes

@DanielVF DanielVF DanielVF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naddison36 @DanielVF @clement-ux