Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-01 Potential Denial of Service in setCrossPrice() #42

Merged
merged 1 commit into from
Dec 9, 2024
Merged

M-01 Potential Denial of Service in setCrossPrice() #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/contracts/AbstractARM.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,9 @@ abstract contract AbstractARM is OwnableOperable, ERC20Upgradeable {
* If the cross price is being lowered, there can not be a significant amount of base assets in the ARM. eg stETH.
* This prevents the ARM making a loss when the base asset is sold at a lower price than it was bought
* before the cross price was lowered.
* The base assets should be sent to the withdrawal queue before the cross price can be lowered.
* The base assets should be sent to the withdrawal queue before the cross price can be lowered. For example, the
* `Owner` should construct a tx that calls `requestLidoWithdrawals` before `setCrossPrice` for the Lido ARM
* when the cross price is being lowered.
* The cross price can be increased with assets in the ARM.
* @param newCrossPrice The new cross price scaled to 36 decimals.
*/
Expand Down