Skip to content

Commit

Permalink
Use calldata instead of memory for external function parameters (#40)
Browse files Browse the repository at this point in the history
  • Loading branch information
naddison36 authored Dec 9, 2024
1 parent f9628c0 commit cc4685a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/contracts/LidoARM.sol
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ contract LidoARM is Initializable, AbstractARM {
* Reference: https://docs.lido.fi/contracts/withdrawal-queue-erc721/
* Note: There is a 1k amount limit. Caller should split large withdrawals in chunks of less or equal to 1k each.)
*/
function requestLidoWithdrawals(uint256[] memory amounts)
function requestLidoWithdrawals(uint256[] calldata amounts)
external
onlyOperatorOrOwner
returns (uint256[] memory requestIds)
Expand All @@ -93,7 +93,7 @@ contract LidoARM is Initializable, AbstractARM {
* @notice Claim the ETH owed from the redemption requests and convert it to WETH.
* Before calling this method, caller should check on the request NFTs to ensure the withdrawal was processed.
*/
function claimLidoWithdrawals(uint256[] memory requestIds) external {
function claimLidoWithdrawals(uint256[] calldata requestIds) external {
uint256 etherBefore = address(this).balance;

// Claim the NFTs for ETH.
Expand Down

0 comments on commit cc4685a

Please sign in to comment.