Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Homebrew options improvements #497

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MeanderingCode
Copy link

@MeanderingCode MeanderingCode commented Dec 18, 2020

Description:

This PR is a WIP for the items listed below. Currently, the options appear on the builder pages and save to the homebrew object, but do not appear to be read correctly in the character builder / viewers. If someone with more familiarity can point me in the right direction (data model issues, something new not added to a reader / renderer?), it would expedite me finishing this. Otherwise, I will poke around more when I have time.

Adds some simple features and changes to some homebrew builder types:

  • Change range of Feat "Weapon Proficiency" choices from 3-5 to 1-5
  • Add "Weapon Prociency" choice to Background builder
  • Add Spell "unlocking" for specific spells to Feat builder

Related issue (if applicable):
Addresses #50 (not complete)
Addresses #172 (comment)

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz
Copy link

datdamnzotz commented Dec 18, 2020

https://github.com/Orcpub/orcpub/pull/497/checks?check_run_id=1579168521

Need to move (defn feat-builder [] under option-spells (around line 5772) so option-spells is defined.
Then it works just fine.
Some reason I can't push to your branch otherwise you'd have the fix

image

@datdamnzotz datdamnzotz added area/application Task related to orcpub application itself enhancement New feature or request labels Dec 18, 2020
@MeanderingCode
Copy link
Author

Need to move (defn feat-builder [] under option-spells (around line 5772) so option-spells is defined.
Then it works just fine.

Thanks, @datdamnzotz. For some reason, I am able to see the section in the view just fine, anyway.

But either way, it does not apply the spells in the Feat to my character, they way the same options in the Subrace Builder do.

Also, any idea why the Weapon Proficiency I added to the Background Builder similarly doesn't apply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application Task related to orcpub application itself enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants