Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix always_on_top for sub-dialogs #1167

Merged
merged 10 commits into from
Feb 5, 2025
Merged

Fix always_on_top for sub-dialogs #1167

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3dec420
Fix Create Folder sub-dialog of Export > Browse being always behind (…
Variable-ind Jan 24, 2025
6a358b3
Add a dedicated tag (makes it easier to remove it if godot itself fix…
Variable-ind Feb 5, 2025
35d2d50
the scecnes themselves have the tag instead of in Main.tscn
Variable-ind Feb 5, 2025
c1619d6
Fix browse->new folder of export dialog
Variable-ind Feb 5, 2025
f91ed1c
fix a typo
Variable-ind Feb 5, 2025
a23e17a
Merge branch 'Orama-Interactive:master' into fix-sub-dialogs
Variable-ind Feb 5, 2025
9746b5b
Restore lines that were unintentionally changed by Godot
Variable-ind Feb 5, 2025
0d57155
Merge branch 'fix-sub-dialogs' of github.com:Variable-ind/Pixelorama …
Variable-ind Feb 5, 2025
557cd7d
simplify the code and move it to the Export Dialog
Variable-ind Feb 5, 2025
4633487
fix artefacts of moving the code
Variable-ind Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/UI/Dialogs/ExportDialog.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ func _ready() -> void:
else:
file_exists_alert_popup.add_button("Cancel Export", false, "cancel")

# TODO: Remove the loop when https://github.com/godotengine/godot/issues/92848 gets fixed.
for dialog_child in path_dialog_popup.get_children(true):
if dialog_child is Window:
dialog_child.always_on_top = path_dialog_popup.always_on_top


func show_tab() -> void:
get_tree().call_group("ExportImageOptions", "hide")
Expand Down