Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add path to fingerprint function #17

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

413n
Copy link
Contributor

@413n 413n commented Apr 30, 2024

Adding the path to the fingerprint function would provide more flexibility to fingerprint the requests based on which procedure has been called

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 33a84b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@413n
Copy link
Contributor Author

413n commented Apr 30, 2024

To be retro-compatible, I added the path as last parameter of the fingerprint function, but I'm open to suggestions

@OrJDev OrJDev merged commit 923ae1e into OrJDev:main Jul 15, 2024
1 check passed
@OrJDev
Copy link
Owner

OrJDev commented Jul 15, 2024

Lgtm ty

@413n 413n deleted the feat/add-path-to-fingerprint branch July 15, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants