Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Card, FlatCard, ImageCard, ResourceCard, and ValueCard components to typescript #1802

Merged
merged 16 commits into from
Mar 4, 2024

Conversation

recondesigns
Copy link
Contributor

Description of changes

Converting components included all test and storybook files for each.

  • Converted Card component to Typescript, removed prop-types, and added a props type
  • Converted FlatCard component to Typescript, removed prop-types, and added a props type
  • Converted ImageCard component to Typescript, removed prop-types, and added a props type
  • Converted ResourceCard component to Typescript, removed prop-types, and added a props type
    • Converted ResourceSkeletonCard component to Typescript, removed prop-types, and added a props type
  • Converted ValueCard component to Typescript, removed prop-types, and added a props type

Issue Resolved

Fixes #NA

Screenshots/GIFs

All .tsx files for Card, FlatCard, and ImageCard

Screenshot 2024-03-03 at 10 06 36 AM

All .tsx files for ResourceCard, and ValueCard`

Screenshot 2024-03-03 at 10 07 10 AM

@recondesigns recondesigns requested a review from kylemh March 3, 2024 16:12
Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 2:01am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 2:01am

Copy link

cypress bot commented Mar 3, 2024

Passing run #4657 ↗︎

0 25 0 0 Flakiness 0

Details:

merging in main
Project: operation_code Commit: 46f6a2bff7
Status: Passed Duration: 03:30 💡
Started: Mar 4, 2024 2:01 AM Ended: Mar 4, 2024 2:05 AM

Review all test suite changes for PR #1802 ↗︎

components/Cards/ImageCard/ImageCard.tsx Outdated Show resolved Hide resolved
components/Cards/ResourceCard/ResourceSkeletonCard.tsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Mar 4, 2024

Code Climate has analyzed commit 46f6a2b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 79.5% (0.0% change).

View more on Code Climate.

@kylemh kylemh merged commit 86554f1 into main Mar 4, 2024
18 checks passed
@kylemh kylemh deleted the migrate-card-components-to-ts branch March 4, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants