Erc4626 extension

[Ifechukwudaniel]

Resolves #356

PR Checklist

• Tests
• Documentation
• Changelog

[netlify]

✅ Deploy Preview for contracts-stylus canceled.

Name	Link
🔨 Latest commit	fc553f2
🔍 Latest deploy log	https://app.netlify.com/sites/contracts-stylus/deploys/6793d7af9fb09800083509ae

[Ifechukwudaniel]

I just stared this

[0xNeshi]

I'll convert this to a draft, so that the team does not invest time reviewing a WIP

[Ifechukwudaniel]

@0xNeshi
The Solidity implementation uses safe transfer

SafeERC20.safeTransferFrom(_asset, caller, address(this), assets);

In the Solidity implementation, SafeERC20 is a utility library. However, in the Stylus implementation, SafeTransfer is a contract. What do you think

[0xNeshi]

@0xNeshi The Solidity implementation uses safe transfer

SafeERC20.safeTransferFrom(_asset, caller, address(this), assets);

In the Solidity implementation, SafeERC20 is a utility library. However, in the Stylus implementation, SafeTransfer is a contract. What do you think

See how VestingWallet handles this

[Ifechukwudaniel]

@bidzyyys for us to implement something like
ERC4626

 function decimals() public view virtual override(IERC20Metadata, ERC20) returns (uint8) {
        return _underlyingDecimals + _decimalsOffset();
    }

Erc4626 storage values should be public