-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reference-types error on nightly version #375
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bd55fff
fix nightly contracts deploy
qalisander e8074db
migrate to actions-rust-lang/setup-rust-toolchain
qalisander 8bdc1cf
++
qalisander c60de32
++
qalisander 5f4505b
++
qalisander d1e0adc
++
qalisander f7c8254
++
qalisander cb66c38
++
qalisander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,20 +19,13 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: set up rust | ||
uses: dtolnay/rust-toolchain@master | ||
id: toolchain | ||
- name: Install rust | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
target: wasm32-unknown-unknown | ||
components: rust-src | ||
toolchain: nightly-2024-01-01 | ||
rustflags: "" | ||
|
||
- uses: Swatinem/rust-cache@v2 | ||
- name: Install cargo-stylus | ||
run: cargo install [email protected] | ||
|
||
- name: install cargo-stylus | ||
run: cargo install [email protected] | ||
|
||
- name: run wasm check | ||
run: | | ||
export NIGHTLY_TOOLCHAIN=${{steps.toolchain.outputs.name}} | ||
./scripts/check-wasm.sh | ||
- name: Run wasm check | ||
run: ./scripts/check-wasm.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,17 @@ jobs: | |
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Install stable | ||
|
||
- name: Install rust | ||
# We run in nightly to make use of some features only available there. | ||
# Check out `rustfmt.toml` to see which ones. | ||
uses: dtolnay/rust-toolchain@nightly | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
toolchain: nightly | ||
components: rustfmt | ||
- name: cargo fmt --all --check | ||
rustflags: "" | ||
|
||
- name: Check formatting | ||
run: cargo fmt --all --check | ||
clippy: | ||
runs-on: ubuntu-latest | ||
|
@@ -55,12 +59,15 @@ jobs: | |
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Install ${{ matrix.toolchain }} | ||
uses: dtolnay/rust-toolchain@master | ||
|
||
- name: Install rust ${{ matrix.toolchain }} | ||
bidzyyys marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
toolchain: ${{ matrix.toolchain }} | ||
components: clippy | ||
- name: cargo clippy | ||
rustflags: "" | ||
|
||
- name: Cargo clippy | ||
uses: giraffate/clippy-action@v1 | ||
with: | ||
reporter: 'github-pr-check' | ||
|
@@ -76,9 +83,14 @@ jobs: | |
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Install nightly | ||
uses: dtolnay/rust-toolchain@nightly | ||
- name: cargo doc | ||
|
||
- name: Install rust | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
toolchain: nightly | ||
rustflags: "" | ||
|
||
- name: Cargo doc | ||
run: cargo doc --no-deps --all-features | ||
env: | ||
RUSTDOCFLAGS: --cfg docsrs | ||
|
@@ -91,23 +103,28 @@ jobs: | |
- uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
- name: Install stable | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: Install rust | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
toolchain: stable | ||
target: wasm32-unknown-unknown | ||
- name: cargo install cargo-hack | ||
rustflags: "" | ||
|
||
- name: Cargo install cargo-hack | ||
uses: taiki-e/install-action@cargo-hack | ||
# Intentionally no target specifier; see https://github.com/jonhoo/rust-ci-conf/pull/4 | ||
# `--feature-powerset` runs for every combination of features. Note that | ||
# target in this context means one of `--lib`, `--bin`, etc, and not the | ||
# target triple. | ||
- name: cargo hack | ||
- name: Cargo hack | ||
run: cargo hack check --feature-powerset --depth 2 --release --target wasm32-unknown-unknown --skip std --workspace --exclude e2e --exclude basic-example-script --exclude benches | ||
typos: | ||
runs-on: ubuntu-latest | ||
name: ubuntu / stable / typos | ||
steps: | ||
- name: Checkout Actions Repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Check spelling of files in the workspace | ||
uses: crate-ci/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# This workflow runs our end-to-end tests suite. | ||
# | ||
# It roughly follows these steps: | ||
# - Install Rust | ||
# - Install rust | ||
# - Install `cargo-stylus` | ||
# - Install `solc` | ||
# - Spin up `nitro-testnode` | ||
|
@@ -26,30 +26,22 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: set up rust | ||
uses: dtolnay/rust-toolchain@master | ||
id: toolchain | ||
- name: Install rust | ||
uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
with: | ||
target: wasm32-unknown-unknown | ||
components: rust-src | ||
toolchain: nightly-2024-01-01 | ||
cache-key: "e2e-tests" | ||
rustflags: "" | ||
|
||
- uses: Swatinem/rust-cache@v2 | ||
with: | ||
key: "e2e-tests" | ||
|
||
- name: install cargo-stylus | ||
run: cargo install [email protected] | ||
- name: Install cargo-stylus | ||
run: cargo install [email protected] | ||
|
||
- name: install solc | ||
- name: Install solc | ||
run: | | ||
curl -LO https://github.com/ethereum/solidity/releases/download/v0.8.21/solc-static-linux | ||
sudo mv solc-static-linux /usr/bin/solc | ||
sudo chmod a+x /usr/bin/solc | ||
|
||
- name: setup nitro node | ||
- name: Setup nitro node | ||
run: ./scripts/nitro-testnode.sh -d -i | ||
- name: run integration tests | ||
run: | | ||
export NIGHTLY_TOOLCHAIN=${{steps.toolchain.outputs.name}} | ||
./scripts/e2e-tests.sh | ||
run: ./scripts/e2e-tests.sh |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas we should write
rustflags: ""
everywhere. Otherwise our optimization rust flags will be replaced by-D warnings
. Strange behavior of this gh action tbh