Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC6909 Implementation along with extensions #5394

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Add ERC6909 Implementation along with extensions #5394

wants to merge 43 commits into from
+919 −0

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Dec 20, 2024 •
edited
Loading

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a9bb063

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arr00 arr00 requested a review from ernestognw December 23, 2024 16:08
ernestognw
ernestognw reviewed Dec 30, 2024
View reviewed changes
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/draft-ERC6909.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/extensions/draft-ERC6909ContentURI.sol Outdated Show resolved Hide resolved
@arr00 arr00 marked this pull request as ready for review January 10, 2025 21:28
Amxx
Amxx reviewed Jan 20, 2025
View reviewed changes
docs/modules/ROOT/nav.adoc Outdated Show resolved Hide resolved
@arr00 @Amxx
Apply suggestions from code review
9f6506b 
Co-authored-by: Hadrien Croubois <[email protected]>
ernestognw
ernestognw reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Few nitpicks, otherwise LGTM

contracts/token/ERC6909/extensions/draft-ERC6909ContentURI.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/extensions/draft-ERC6909ContentURI.sol Outdated Show resolved Hide resolved
contracts/token/ERC6909/extensions/draft-ERC6909TokenSupply.sol Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

@Amxx Amxx Amxx left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arr00 @ernestognw @Amxx