Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.6 #33

Merged
merged 1 commit into from
Jan 28, 2024
Merged

1.0.6 #33

merged 1 commit into from
Jan 28, 2024

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Jan 24, 2024

I'd like to release the current version so we can move forward with testing in OpenZeppelin/openzeppelin-contracts#3617

@Amxx Amxx requested a review from ernestognw January 24, 2024 12:37
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's merge this and continue with the MerkleTree builder PR

@frangio
Copy link
Contributor

frangio commented Jan 27, 2024

FYI, this repo is released manually via npm version + npm publish. Pushing the tag will create a GitHub release automatically.

@Amxx
Copy link
Contributor Author

Amxx commented Jan 27, 2024

FYI, this repo is released manually via npm version + npm publish. Pushing the tag will create a GitHub release automatically.

There is a security thing preventing me from pushing directly to master.

I wanted to do:

  • nom version
  • git push
  • npm publish
    But step 2 was blocked and it did not feel right to publish a commit that is not on the master branch.

That is why I created this PR and planned to tag and publish the commit that result from this being merged. It that ok or should we do the release differently ?

@frangio
Copy link
Contributor

frangio commented Jan 27, 2024

Yes that sounds good!

@Amxx Amxx merged commit 0d55cb0 into master Jan 28, 2024
3 checks passed
@Amxx Amxx deleted the release/v1.0.6 branch January 28, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants