Fix: Framerate parsing in gst mtl plugins #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GST_TYPE_FRACTION as the type for the framerate parameter in the plugins instead of hardcoded enums. Signed-off-by: Kasiewicz, Marek <[email protected]>
Sakoram
requested review from
DawidWesierski4,
skolelis and
Falron98
as code owners
DawidWesierski4
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Please before merging add the changes to the README.md
Also to the commit message add the information about removing the dead fps code from st30 adjusting the tests
Add the information that we will support fractial fps after this pr
all of which are the scope of this PR
Great work LGTM
Signed-off-by: Kasiewicz, Marek <[email protected]>
Signed-off-by: Kasiewicz, Marek <[email protected]>
Update: parameters description in README Signed-off-by: Kasiewicz, Marek <[email protected]>
Sakoram
force-pushed
the
fix_gst_st20_fps
branch
from
959625b to
95dab8f
Compare
DawidWesierski4
approved these changes
Feb 6, 2025
Sakoram
added a commit
to Sakoram/Media-Transport-Library
that referenced
this pull request
Feb 6, 2025
- Use GST_TYPE_FRACTION as the type for the framerate parameter in the plugins instead of hardcoded enums. - Update parameters description in README - Remove fps parameter from gst_mtl_st20p_tx, gst_mtl_st30p_tx, gst_mtl_st30p_rx This fixes fractional fps support --------- Signed-off-by: Kasiewicz, Marek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes fractional fps support