Update date field handling #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit setting the value of a date field to the current date required changing the date picker to some other value and then changing it back to the current date. This commit fixes that workflow by setting the date field value on focus and adding a toolbar with a "Clear" button to remove the value if it was set accidentally. To properly clear a previously saved date value required changing the implementation of `updateDictWithValueFromCell:` to set an `NSNull` in the dictionary rather than omitting the key from the dictionary entirely.
The `updatedString` property is nil in two situations, the field was initially empty or an initially non-empty field was cleared. To remove the ambiguity I added two new properties to keep track of the initial value of the field and whether or not it was cleared by the user.
Some date strings include a `00:00` time that was causing string to date object conversions to fail. We have implemented a simple solution, falling back to trying to parse the date+time format if parsing the date-only format returns nil.
|
Reopening to connect with issues. |
flibbertigibbet
approved these changes
Sep 25, 2017
| { | ||
| NSDateFormatter *dateFormatter = [[NSDateFormatter alloc] init]; | ||
| [dateFormatter setDateFormat:OTMEnvironmentDateStringShort]; | ||
| NSDate *newDate=[dateFormatter dateFromString:dateString]; |
There was a problem hiding this comment.
Might want to format with spaces around equals sign here
There was a problem hiding this comment.
Deferring this whitespace fix to to avoid spending time rebasing and retesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit setting the value of a date field to the current date required changing the date picker to some other value and then changing it back to the current date. This commit fixes that workflow by setting the date field value on focus and adding a toolbar with a "Clear" button to remove the value if it was set accidentally.
To properly clear a previously saved date value required changing the implementation of
updateDictWithValueFromCell:to set anNSNullin the dictionary rather than omitting the key from the dictionary entirely.The
updatedStringproperty is nil in two situations, the field was initially empty or an initially non-empty field was cleared. To remove the ambiguity I added two new properties to keep track of the initial value of the field and whether or not it was cleared by the user.Some date strings include a
00:00time that was causing string to date object conversions to fail. We have implemented a simple solution, falling back to trying to parse the date+time format if parsing the date-only format returns nil.Testing
Date default and clear button
Date Plantedfield. Save the tree and verify that the current date is saved as the value ofDate PlantedDate Plantedfield, and click theClearbutton. Save the tree and verify that the value has been removed from the tree.Persistence, clearing, and display
Connects to #217
Connects to #357