New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous elections pages #518

Merged

smarcet merged 32 commits into master from hotfix/previous-elections-pages

Nov 9, 2023

Contributor

tomrndom commented Oct 18, 2023

Reuses template for previous elections pages
Generate pages in build time with data from API

ref: https://tipit.avaza.com/project/view/188886#!tab=task-pane&task=3400289

Signed-off-by: Tomás Castillo [email protected]

tomrndom added 2 commits

October 18, 2023 06:19


          Previous election page

65cb80c

Signed-off-by: Tomás Castillo <[email protected]>


          Change in templates for previous candidates pages

433b4b7

Signed-off-by: Tomás Castillo <[email protected]>

tomrndom requested a review from smarcet

October 18, 2023 10:09

tomrndom and others added 10 commits

October 18, 2023 15:55


          Update branch-deploy env vars

23909e7

Signed-off-by: Tomás Castillo <[email protected]>


          Add missing env variables to branch deploy context

faa4553

Signed-off-by: Tomás Castillo <[email protected]>


          Change context to deploy-preview

9a97843

Signed-off-by: Tomás Castillo <[email protected]>


          Change .toml indentation

31e5838

Signed-off-by: Tomás Castillo <[email protected]>


          Changes in netlify.toml file

fcedc2e

Signed-off-by: Tomás Castillo <[email protected]>


          Pass sponsored project id as string on toml file

7d5ebfc

Signed-off-by: Tomás Castillo <[email protected]>


          Tweaks for real dynmamic pages

fd122b9


          Merge pull request #519 from OpenStackweb/hotfix/previous-elections-p…

e4ec266

…ages-dynamic

Tweaks for real dynmamic pages


          Adjusting elections qty to generate pages, add SEO to markdown files

bc2e5f2

Signed-off-by: Tomás Castillo <[email protected]>


          Remove console log on election gold previos page

9d8318c

Signed-off-by: Tomás Castillo <[email protected]>

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

static/admin/config.yml Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

static/admin/config.yml Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

static/admin/config.yml Outdated Show resolved Hide resolved

smarcet requested changes

View reviewed changes

Contributor

smarcet left a comment

@tomrndom please review comments
much thanks!

smarcet reviewed

View reviewed changes

src/pages/election/index.md Show resolved Hide resolved

smarcet reviewed

View reviewed changes

src/pages/election/candidates/index.md Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

src/pages/election/candidates/gold/index.md Show resolved Hide resolved

tomrndom added 3 commits

October 20, 2023 10:56


          Rollback current election .md files, adjust env variables and cms

88957f9


          Eletion id field on cms hidden

9c2fca9

Signed-off-by: Tomás Castillo <[email protected]>


          Remove console log

a5db706

Signed-off-by: Tomás Castillo <[email protected]>

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

smarcet reviewed

View reviewed changes

gatsby-node.js Outdated Show resolved Hide resolved

tomrndom and others added 3 commits

October 23, 2023 18:22


          Default values for elections variables, add env template

2ce8ab8

Signed-off-by: Tomás Castillo <[email protected]>


          Adjust package.json file

37f1282

Signed-off-by: Tomás Castillo <[email protected]>


          repointed CMS branch

195290b

smarcet self-requested a review

October 24, 2023 13:51

smarcet approved these changes

View reviewed changes

Contributor

smarcet left a comment

LGTM
before merge we need to change the branch on CMS config and remove the extra config from .toml file

tomrndom and others added 7 commits

October 24, 2023 19:07


          Fix cms files, add current election data, add redirects

c966e12

Signed-off-by: Tomás Castillo <[email protected]>


          Remove redirects from .toml file

826ce50

Signed-off-by: Tomás Castillo <[email protected]>


          Fix CMS paths for elections

022882d

Signed-off-by: Tomás Castillo <[email protected]>


          trigger deploy

efbe935

Signed-off-by: Tomás Castillo <[email protected]>


          Move redirects from forEach, election template paths function

03b8b87

Signed-off-by: Tomás Castillo <[email protected]>


          Update Election Pages “electionPage”

8d1c94d


          Update Election Pages “electionPage”

4cc8750

Contributor

iamweswilson commented Oct 30, 2023

I updated the CMS and that worked well. I'm not sure if I missed some areas in the CMS, but ran into an inconsistency when clicking through the preview. As you can see in this video, going to "Gold Member Elections" takes you to the right url, but the wrong title. Clicking "Election Details" from that page takes you back to 2023 elections.

Browser metadata

Path:      /election/2023-individual-director-election
Browser:   Chrome 118.0.0.0 on Mac OS 10.15.7
Viewport:  1404 x 1072 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

smarcet and others added 7 commits

October 31, 2023 10:09


          Update config.yml

34a876b


          Update config.yml

a4c3644


          Update Election Pages “electionGoldCandidatesPage”

53d50ec


          Update Election Pages “electionCandidatesPage”

32c2487


          Update Election Pages “electionPage”

3e01109


          Update Election Pages “electionPage”

4c6adb5


          Update config.yml

94d349d

repointed cms branch

smarcet merged commit dfa6bd8 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet