Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG add <nav> tag in proposals index #1243

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BarbaraOliveira13
Copy link

🎩 What?
Wraps the menu-bar__secondary-dropdown__menu element in a

tag with appropriate ARIA attributes, to ensure better semantic structure and improved accessibility.

🎩 Why?
This change addresses accessibility issues by aligning the markup with WCAG 1.3.1 - Info and Relationships. It ensures that the menu is programmatically identified as navigation, providing better support for assistive technologies.

📌 Related Issues
WCAG Criterion: 1.3.1 - Info and Relationships

Steps to Test

  1. Navigate to a paginated proposals index page (e.g., /processes/budget-participatif/f/1/proposals?page=2).
  2. Inspect the HTML structure of the dropdown menu:
  • The menu-bar__secondary-dropdown__menu is wrapped in a tag.
  • The includes the attributes role="navigation" and aria-label.

📋 Subtasks

  • Wrapped menu-bar__secondary-dropdown__menu in a <nav> tag
  • Added role="navigation" and aria-label="Secondary menu" to the tag.
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Capture d’écran 2025-01-09 à 17 23 22

Additional context
This issue originates from an accessibility audit funded by the city of Lyon, targeting compliance with RGAA and corresponding WCAG standards. The changes ensure clearer navigation and improved usability for assistive technologies.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@BarbaraOliveira13 BarbaraOliveira13 force-pushed the wcag/nav-menu-in-proposal-index branch from a32d203 to 6a7f2bd Compare January 14, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant