Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG add pagination to title #1242

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

BarbaraOliveira13
Copy link

@BarbaraOliveira13 BarbaraOliveira13 commented Jan 7, 2025

🎩 What?

This PR addresses the issue where the current page number and the total number of pages were missing from the <title> tag on paginated proposal index pages.

🎩 Why?

This change aligns with WCAG 2.4.2 - Page Titled
and WCAG 2.4.8 - Location. It provides users with clear and contextual information about their location within paginated content.

📌 Related Issues

decidim#13809

WCAG 2.4.2 - Page Titled
WCAG 2.4.8 - Location

Steps to Test

  1. Navigate to a paginated proposals index page in your local environment (e.g., /processes/budget-participatif/f/1/proposals?page=2).
  2. Inspect the <title> tag in the browser’s developer tools.
  3. Confirm the title includes:
  • The current page number
  • The total number of pages

📋 Subtasks

  • Updated the <title> tag in decidim-proposals/app/views/decidim/proposals/proposals/index.html.erb to dynamically include: the current page number and the total number of pages in the paginated proposals list.
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Capture d’écran 2025-01-08 à 11 38 25

Additional context
This issue originates from an accessibility audit funded by the city of Lyon, targeting compliance with RGAA and corresponding WCAG standards. The changes ensure clearer navigation and improved usability for assistive technologies.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review January 8, 2025 10:56
Copy link

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
The title content should be in a translation key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants