Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cookies link to ensure RGAA #1236

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AyakorK
Copy link

@AyakorK AyakorK commented Dec 3, 2024

Describe the bug

The link for "cookies settings" in the footer has an inappropriate role attribute for accessibility. This prevents proper functionality for keyboard users and assistive technologies as VoiceOver, NVDA...

More precisely, when it was a link, we couldn't interact with it using the Spacebar and it wasn't identified as it is, a button that permits to open a modal (not a link that permits to navigate somewhere else)

Expected behavior to ensure RGAA

  • The "cookies settings" link should have the role="button" attribute
  • It should be possible to open the modal using the keyboard key

To Reproduce

  1. On the homepage, go to the footer
  2. Locate "cookies settings" link
  3. As keyboard users: attempt to open the modal with keyboard navigation: <ENTER> + <TAB> + <SPACE>
  4. For assistive technologies: inspect the HTML and verify that the tag don't have role="button" attribute

📋 Subtasks

  • Change link to button

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@AyakorK AyakorK changed the title fix(rgaa): Change cookies link to ensure RGAA Change cookies link to ensure RGAA Dec 3, 2024
@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review December 9, 2024 17:55
@BarbaraOliveira13 BarbaraOliveira13 changed the title Change cookies link to ensure RGAA fix: Change cookies link to ensure RGAA Dec 10, 2024
@BarbaraOliveira13 BarbaraOliveira13 changed the title fix: Change cookies link to ensure RGAA Change cookies link to ensure RGAA Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant