Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conference registering change requests #1222

Conversation

BarbaraOliveira13
Copy link

🎩 What? Why?

Add rspec for has_published_registration_types? method in conference model

📌 Related Issues

  • Related to #?
  • Fixes #?

📋 Subtasks

📷 Screenshots (optional)

Description

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@BarbaraOliveira13 BarbaraOliveira13 marked this pull request as ready for review April 25, 2024 07:17
Copy link

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great tests, thx @BarbaraOliveira13

@Quentinchampenois Quentinchampenois changed the title Fix/conference registering change requests Conference registering change requests Apr 25, 2024
@Quentinchampenois Quentinchampenois added the type: change Change requests label Apr 25, 2024
Copy link

@Quentinchampenois Quentinchampenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello thanks for the tests, I just have a suggestion on the conference_registrations system specs !

decidim-conferences/.idea/misc.xml Fixed Show fixed Hide fixed
decidim-conferences/.idea/modules.xml Fixed Show fixed Hide fixed
decidim-conferences/.idea/vcs.xml Fixed Show fixed Hide fixed
decidim-conferences/.idea/vcs.xml Fixed Show fixed Hide fixed
decidim-conferences/.idea/vcs.xml Fixed Show fixed Hide fixed
decidim-conferences/.idea/misc.xml Fixed Show fixed Hide fixed
@Stef-Rousset Stef-Rousset force-pushed the Fix/conference_registering_change_requests branch from 50b535c to 9f0fcaf Compare April 25, 2024 09:48
@Quentinchampenois Quentinchampenois merged commit cf08f85 into Fix/conference_registering Apr 25, 2024
43 checks passed
@Quentinchampenois Quentinchampenois deleted the Fix/conference_registering_change_requests branch April 25, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: change Change requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants