Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to configure notifications_sending_frequency #183

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

Quentinchampenois
Copy link
Contributor

@Quentinchampenois Quentinchampenois commented Feb 29, 2024

🎩 Description

Please describe your pull request.

Allow to configure notifications_sending_frequency with ENV var NOTIFICATIONS_SENDING_FREQUENCY

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Example:

  • Run server with env var : NOTIFICATIONS_SENDING_FREQUENCY=none bundle exec rails s
  • Create registration
  • Login and check "My account"

Tasks

  • Add specs
  • Add note about overrides in OVERLOADS.md
  • In case of new dependencies or version bump, update related documentation

📷 Screenshots

Please add screenshots of the changes you're proposing if related to the UI

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.12%. Comparing base (a80cb3c) to head (b262ebd).

Additional details and impacted files
@@             Coverage Diff             @@
##           rc/0.27     #183      +/-   ##
===========================================
- Coverage    87.57%   86.12%   -1.46%     
===========================================
  Files           68       68              
  Lines         1650     1650              
===========================================
- Hits          1445     1421      -24     
- Misses         205      229      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quentinchampenois Quentinchampenois marked this pull request as ready for review March 1, 2024 10:43
@luciegrau luciegrau self-requested a review March 1, 2024 10:44
@luciegrau luciegrau merged commit 7687ef5 into rc/0.27 Mar 1, 2024
15 of 16 checks passed
@luciegrau luciegrau deleted the feat/notifications_sending_frequency branch March 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants