Skip to content

Commit

Permalink
fix: Add matrix spec in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Quentinchampenois committed Nov 16, 2023
1 parent ecd89c2 commit c1e5777
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 8 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/ci_cleaner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,24 @@ jobs:
DATABASE_USERNAME: postgres
DATABASE_PASSWORD: postgres
DATABASE_HOST: localhost
matrix:
include:
- decidim-version: '0.28.0'
ruby-version: '3.1.1'
node-version: '18.15.0'
gemfile: 'Gemfile'
steps:
- uses: rokroskar/[email protected]
if: "github.ref != 'refs/heads/develop'"
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
- uses: OpenSourcePolitics/rspec-action@master
env:
DECIDIM_VERSION: ${{ matrix.decidim-version }}
RUBY_VERSION: ${{ matrix.ruby-version }}
NODE_VERSION: ${{ matrix.node-version }}
WEBPACKER_RUNTIME_COMPILE: ${{ matrix.webpacker-runtime-compile }}
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
with:
command: "bundle exec rspec --exclude-pattern 'spec/system/**/*_spec.rb'"
system_tests:
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ PATH
remote: .
specs:
decidim-cleaner (4.1.2)
decidim-core (~> 0.28.dev)
decidim-core (>= 0.26.0, < 0.29)

GEM
remote: https://rubygems.org/
Expand Down
2 changes: 1 addition & 1 deletion decidim-cleaner.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ Gem::Specification.new do |s|

s.files = Dir["{app,config,db,lib}/**/*", "LICENSE-AGPLv3.txt", "Rakefile", "README.md"]

s.add_dependency "decidim-core", "~> #{Decidim::Cleaner.compatible_decidim_version}"
s.add_dependency "decidim-core", Decidim::Cleaner::COMPAT_DECIDIM_VERSION
end
8 changes: 2 additions & 6 deletions lib/decidim/cleaner/version.rb
Original file line number Diff line number Diff line change
@@ -1,16 +1,12 @@
# frozen_string_literal: true

# :nocov:
module Decidim
# This holds the decidim-meetings version.
module Cleaner
def self.version
"4.1.2"
end

def self.compatible_decidim_version
"0.28.dev"
end
COMPAT_DECIDIM_VERSION = [">= 0.26.0", "< 0.29"].freeze
end
end
# :nocov:
end

0 comments on commit c1e5777

Please sign in to comment.