-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 57 biomodels #84
Conversation
…SED-ML files without them being overwritten (use_original_files)
…with modified x limit
@robertvi I've updated the BIOMD0000000001 plots and results table (and increased the max_wait_time to 600 seconds so that there is enough time for Amici to run) but I think this should be ready now to be merged into dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the compatibility column says XFAIL but the message says "the filetype suggests it maybe compatible" it is a bit unclear then why this is an expected fail. If the script knows the program cannot handle this type of model should the message state this clearly perhaps?
BioModels/BIOMD0000000001/tests/results_compatibility_biosimulators.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving the UNSURE versus XFAIL issue until another PR
Good point. #89 looks at the compatibility message, will address this comment there. |
Issue #57