Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 57 biomodels #84

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Feat 57 biomodels #84

merged 16 commits into from
Nov 25, 2024

Conversation

stellaprins
Copy link
Collaborator

@stellaprins stellaprins commented Nov 14, 2024

Issue #57

  • Add results tables for BIOMD0000000138 and BIOMD0000000001
  • SED-ML files are tweeked to replicated curated BioModels figures (e.g. log scale, end time, plotted curves)

@stellaprins
Copy link
Collaborator Author

@robertvi I've updated the BIOMD0000000001 plots and results table (and increased the max_wait_time to 600 seconds so that there is enough time for Amici to run) but I think this should be ready now to be merged into dev

Copy link
Collaborator

@robertvi robertvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the compatibility column says XFAIL but the message says "the filetype suggests it maybe compatible" it is a bit unclear then why this is an expected fail. If the script knows the program cannot handle this type of model should the message state this clearly perhaps?

utils/__init__.py Outdated Show resolved Hide resolved
This was referenced Nov 25, 2024
Copy link
Collaborator

@robertvi robertvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving the UNSURE versus XFAIL issue until another PR

@stellaprins
Copy link
Collaborator Author

When the compatibility column says XFAIL but the message says "the filetype suggests it maybe compatible" it is a bit unclear then why this is an expected fail. If the script knows the program cannot handle this type of model should the message state this clearly perhaps?

Good point. #89 looks at the compatibility message, will address this comment there.

@stellaprins stellaprins merged commit bfc5f39 into development Nov 25, 2024
24 checks passed
@stellaprins stellaprins deleted the feat-57-biomodels branch December 2, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants