Display file is blocked or not. #2185
Conversation
src/OVAL/probes/probe-api.c
Outdated
| @@ -1807,6 +1807,7 @@ bool probe_path_is_blocked(const char *path, struct oscap_list *blocked_paths) | |||
| } | |||
| } | |||
| oscap_iterator_free(it); | |||
| dD("Path:%s, res:%d", path, res); | |||
There was a problem hiding this comment.
That's a very generic message. I'd suggest something like
| dD("Path:%s, res:%d", path, res); | |
| dD("Path: %s, blocked (res): %d", path, res); |
There was a problem hiding this comment.
And maybe it makes sense to only output the message if the path is blocked? Otherwise it'd be very noisy IMHO. What are you debugging actually?
There was a problem hiding this comment.
Hi @evgenyz , your modification also looks good. In practice, OpenSCAP is very easy to trigger OOM issue and make other critical processes being killed. About 80% of these issues are due to unbridled rules that accessing lots of files of unwanted folder. This debug message can help to show the paths already be blocked.
There was a problem hiding this comment.
The thing is, there will be a lot of Path: /foo/bar/, blocked (res): 0 messages in the output, they will litter the log while not really helping any investigation (since these files will be processed and will popup somewhere else in the logs anyways).
Showing the result can help isolating some memory consuming issue.