-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process headers to ensure compatibility between legacy and netty validation #30632
Open
mrsaldana
wants to merge
4
commits into
OpenLiberty:netty-transport-http
Choose a base branch
from
mrsaldana:netty-transport-http-responseMessageImprovements
base: netty-transport-http
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Process headers to ensure compatibility between legacy and netty validation #30632
mrsaldana
wants to merge
4
commits into
OpenLiberty:netty-transport-http
from
mrsaldana:netty-transport-http-responseMessageImprovements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaldana
force-pushed
the
netty-transport-http-responseMessageImprovements
branch
from
January 24, 2025 14:33
324000c
to
7b70122
Compare
pnicolucci
reviewed
Jan 28, 2025
dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyResponseMessage.java
Show resolved
Hide resolved
pnicolucci
reviewed
Jan 28, 2025
dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/outbound/HeaderHandler.java
Show resolved
Hide resolved
pnicolucci
reviewed
Jan 28, 2025
dev/com.ibm.ws.transport.http/src/io/openliberty/http/netty/channel/utils/HeaderValidator.java
Show resolved
Hide resolved
pnicolucci
reviewed
Jan 28, 2025
dev/com.ibm.ws.transport.http/src/io/openliberty/http/netty/channel/utils/HeaderValidator.java
Show resolved
Hide resolved
Enhancements for translating warning messages on validator will be resolved by #30653 |
pnicolucci
previously approved these changes
Jan 28, 2025
isaacrivriv
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!!
mrsaldana
dismissed stale reviews from isaacrivriv and pnicolucci
via
January 30, 2025 14:55
da35211
mrsaldana
force-pushed
the
netty-transport-http-responseMessageImprovements
branch
from
January 30, 2025 15:48
da35211
to
1f5747e
Compare
mrsaldana
force-pushed
the
netty-transport-http-responseMessageImprovements
branch
from
January 31, 2025 11:47
1f5747e
to
ba62532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).This PR introduces a
HeaderValidator
utility class for validating HTTP header names and values. Validation is made to comply with RFC 7230, Section 3.2. This RFC refers to "HTTP/1.1 Message Syntax and Routing" and Section 3.2 covers "Header Fields". In addition to enforcing strict checks to ensure the header is compliant, the utility normalizes the tokens by stripping whitespace padding and lower-casing header field names.Testing
The accompanying unit tests confirm expected behaviors on:
Usage