Set OIDC Client ID in Thread AccesTokenAuthenticator #30626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a need to add the client id to the thread when the method getIssuerIdentifier is invoked.
wrodrig
force-pushed
the
add-setThreadClientID-IssuerIdentifier
branch
from
7219aca to
9e19953
Compare
wrodrig
changed the title
|
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
wrodrig
force-pushed
the
add-setThreadClientID-IssuerIdentifier
branch
from
9e19953 to
7e1d5f4
Compare
|
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
1 similar comment
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
wrodrig
force-pushed
the
add-setThreadClientID-IssuerIdentifier
branch
from
7e1d5f4 to
0e54250
Compare
|
!Libby (view Open Liberty Delivery Requirements Verification - ✅ completed successfully!) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
ayoho
approved these changes
Jan 27, 2025
|
!build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Failures don't seem to be related to my changes. I'm merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are setting the clientID in the thread only when there is no inbound propagation. However we also need it when inbound propagation happens.
Fixes #PH61850
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).