Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test checkpoint/restore with AES decryption for basicRegistry #30624

Open
wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Test checkpoint/restore with AES decryption for basicRegistry #30624

wants to merge 2 commits into from

Conversation

anjumfatima90
Copy link
Contributor

@anjumfatima90 anjumfatima90 commented Jan 23, 2025 •
edited
Loading

for #30603

@anjumfatima90 anjumfatima90 changed the title Test checkpoint/restore with AES description for basicRegistry Test checkpoint/restore with AES decryption for basicRegistry Jan 23, 2025
@anjumfatima90 anjumfatima90 force-pushed the checkpoint-aes branch 2 times, most recently from ac1250e to 841fbc5 Compare January 23, 2025 18:34
tjwatson
tjwatson reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I just have a few suggestions/questions.

...gistry.basic_fat/publish/servers/com.ibm.ws.security.registry.basic.fat/bootstrap.properties Outdated
@@ -13,3 +13,4 @@
com.ibm.ws.logging.trace.specification=*=info=enabled:com.ibm.ws.security.registry.basic.*=all=enabled

bootstrap.include=../testports.properties
io.openliberty.checkpoint.allowed.features=basicRegistryInternals-1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update the test feature to support InstantOn instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...m.ws.security.registry.basic_fat/fat/src/com/ibm/ws/security/registry/basic/fat/FATTest.java Outdated
public class FATTest {
private static final String DEFAULT_CONFIG_FILE = "basic.server.xml.orig";
private static final String ALTERNATE_BASIC_REGISTRY_CONFIG = "alternateBasicRegistry.xml";
private static final String DEFAULT_AES_CONFIG_FILE = "defaultAESBasicRegistry.xml";
private static final String CUSTOM_AES_CONFIG_FILE = "customAESBasicRegistry.xml";
private static final String DEFAULT_HASH_CONFIG_FILE = "defaultHashBasicRegistry.xml";
private static String serverConfigurationFile = DEFAULT_CONFIG_FILE;
private static LibertyServer server = LibertyServerFactory.getLibertyServer("com.ibm.ws.security.registry.basic.fat");
public static LibertyServer server;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this to public?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I changed it by mistake. Will make it private.

...m.ws.security.registry.basic_fat/fat/src/com/ibm/ws/security/registry/basic/fat/FATTest.java Outdated
Comment on lines 67 to 68
Log.info(c, "serverSetUp", "Creating servlet connection the server");
servlet = new UserRegistryServletConnection(server.getHostname(), server.getHttpDefaultPort());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these two lines go after calling serverStart() in the public static void serverStart(ServerMode, LibertyServer) method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I will update it.

@anjumfatima90
Copy link
Contributor Author

anjumfatima90 commented Jan 23, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 13 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@anjumfatima90
Copy link
Contributor Author

anjumfatima90 commented Jan 23, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

tjwatson
tjwatson previously approved these changes Jan 23, 2025
View reviewed changes
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 12 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

Zech-Hein
Zech-Hein previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Zech-Hein Zech-Hein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_SEgJENo_Ee-0yqtOHBleJw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3lazcNpEEe-0yqtOHBleJw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@anjumfatima90 anjumfatima90 dismissed stale reviews from Zech-Hein and tjwatson via 8a355ec January 24, 2025 16:56
@anjumfatima90
Copy link
Contributor Author

anjumfatima90 commented Jan 24, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ⏳InProgress)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 14 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zech-Hein Zech-Hein Zech-Hein left review comments

@tjwatson tjwatson tjwatson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anjumfatima90 @LibbyBot @tjwatson @Zech-Hein