Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EE Repeats for EJB V32 FAT #30612

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Add EE Repeats for EJB V32 FAT #30612

merged 5 commits into from
Jan 25, 2025

Conversation

tkburroughs
Copy link
Member

  • Add RepeatActions to EJB V32 FAT tests

  • Fix EJB metadata types in Simplicity so RepeatActions may update server.xml

  • Update other tests that were programmatically setting EJB attributes with incorrect types

  • I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).

  • If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).

  • If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

@tkburroughs
Add EE Repeats for EJB V32 FAT
ada76dd 
- Add RepeatActions to EJB V32 FAT tests
- Fix EJB metadata types in Simplicity so RepeatActions may update server.xml
- Update other tests that were programmatically setting EJB attributes with incorrect types
@tkburroughs tkburroughs requested a review from brideck January 22, 2025 22:10
@tkburroughs tkburroughs self-assigned this Jan 22, 2025
@tkburroughs
Copy link
Member Author

tkburroughs commented Jan 22, 2025 •
edited by LibbyBot
Loading

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

KyleAure
KyleAure previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@KyleAure KyleAure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions below are based off the standard use of repeats I've seen in the past. Not sure if using NO_REPLACEMENT vs EE7_FEATURES will have any impact besides to performance.

...m.ws.ejbcontainer.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/PassivationTest.java Show resolved Hide resolved
...ontainer.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/SingletonLifecycleTxTest.java Show resolved Hide resolved
...container.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/StatefulLifecycleTxTest.java Show resolved Hide resolved
@tkburroughs @KyleAure
Use NO_REPLACEMENT instead of EE7_FEATURES in dev/com.ibm.ws.ejbconta…
d6602ba 
…iner.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/PassivationTest.java

Co-authored-by: Kyle Aure <[email protected]>
tkburroughs and others added 2 commits January 22, 2025 17:21
@tkburroughs @KyleAure
Use NO_REPLACEMENT instead of EE7_FEATURES in dev/com.ibm.ws.ejbconta…
d5ebbf5 
…iner.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/SingletonLifecycleTxTest.java

Co-authored-by: Kyle Aure <[email protected]>
@tkburroughs @KyleAure
Use NO_REPLACEMENT instead of EE7_FEATURES in dev/com.ibm.ws.ejbconta…
6fcc031 
…iner.v32_fat/fat/src/com/ibm/ws/ejbcontainer/v32/fat/tests/StatefulLifecycleTxTest.java

Co-authored-by: Kyle Aure <[email protected]>
KyleAure
KyleAure previously approved these changes Jan 23, 2025
View reviewed changes
@tkburroughs tkburroughs requested a review from KyleAure January 24, 2025 17:11
@tkburroughs
Copy link
Member Author

tkburroughs commented Jan 24, 2025 •
edited by LibbyBot
Loading

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 2 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@tkburroughs
Copy link
Member Author

One failure in build is in unrelated fat and intermittent.

@tkburroughs tkburroughs merged commit 03b99ea into OpenLiberty:integration Jan 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAure KyleAure KyleAure approved these changes

@brideck brideck Awaiting requested review from brideck

Assignees

@tkburroughs tkburroughs

Labels
CLA Signed in:EJB Container noproductcode team:Zombie Apocalypse test debt
Projects
None yet
Milestone
[Iteration 25.2] Jan 20 - Jan 31
Development

Successfully merging this pull request may close these issues.
3 participants
@tkburroughs @LibbyBot @KyleAure