Pkg test #30586

utle · 2025-01-18T18:09:12Z

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

################################################################################################

Delete this section and fill in the remaining info from the template

ATTENTION, READ THIS: Updated July 2024

Read and understand this completely, then delete the static part of the template.

If a reviewer or merger sees this template, they should fail the review or merge.

If this code change is fixing a user-visible bug in previously released code, it MUST
have an associated issue mentioned in the PR text or description.

That Issue also MUST be labelled “release bug”

This directs automation to scrape this fix for inclusion in the next release's
list of bugs fixed.
The linkage between PR and Issue should use the Fixes #... syntax rather than a manual
link via the Development widget.

Otherwise, a link to an issue or specific issue labels are optional.

For full details, please see this wiki page: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions
################################################################################################

Rename generate3DESKey method to generateSharedKey

Fips work

…Swork

add common crypto to ssl feature

Fip swork

utle · 2025-01-18T18:10:47Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

utle · 2025-01-18T18:17:54Z

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-18T18:18:10Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
71 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-18T18:18:10Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

utle · 2025-01-18T18:21:23Z

!build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot · 2025-01-18T18:25:26Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
71 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-18T18:25:27Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2025-01-18T18:28:57Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

455 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
2 unit test files were changed.
Check that the build did not break the affected unit test suite(s).
8 infrastructure code files were changed.
9 test infrastructure code files were changed.
Test failures/errors in the build could be due to these changes.
71 product code files were changed.
Please describe in a separate comment how you tested your changes.
16 messages files were changed and need an L2 review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops
16 NLS files were changed and need an ID review.
@OpenLiberty/message-reviewer Please review.
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh_TW.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_it.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_zh.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_cs.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ja.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_fr.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages.nlsprops
- dev/com.ibm.ws.kernel.service/resources/com/ibm/ws/kernel/pseudo/internal/resources/Messages.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_de.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pt_BR.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ro.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ru.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_pl.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_hu.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_ko.nlsprops
- dev/com.ibm.ws.crypto.common/resources/com/ibm/ws/crypto/common/resources/CryptoCommonMessages_es.nlsprops

LibbyBot · 2025-01-18T18:28:58Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

dmuelle · 2025-01-21T13:51:55Z

Hi @utle - are there new messages that need ID review in this or the other FIPS prs with ~544 files? They are showing up in our queue but Im not sure if these are new messages to review or existing messages that are just being moved

utle · 2025-01-22T15:11:06Z

Hi @utle - are there new messages that need ID review in this or the other FIPS prs with ~544 files? They are showing up in our queue but Im not sure if these are new messages to review or existing messages that are just being moved

Hi David,
No these msgs already went through the review in other PR.

mshah0722 and others added 30 commits September 13, 2024 17:38

Supporting FIPS work

6f1eb56

Minor bug fixes

7efb1ad

Minor changes

5f4264e

Use the common crypto bundle

9530112

Create the Provider class

67ca4cb

clean up

3b6d858

Adding support to client and server for java 17

a671f21

Rename generate3DESKey method to generateSharedKey

a90e9bf

Merge branch 'OpenLiberty:integration' into FIPSwork

85c2c57

Fixing some test bugs

a4fa8ba

Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into HEAD

e1cbd56

Merge pull request OpenLiberty#1 from utle/FIPSwork

cf9acf4

Rename generate3DESKey method to generateSharedKey

Minor bugs

d65866e

Added debug msgs

c04b999

SSL to use crypto common code

2123cf5

Merge pull request OpenLiberty#2 from utle/FIPSwork

af2fe51

Fips work

Merge branch 'OpenLiberty:integration' into FIPSwork

7df6665

Restrict TLS versions for FIPS

cde667d

Merge branch 'FIPSwork' of github.com:mshah0722/open-liberty into FIP…

2f16885

…Swork

Restrict TLS versions for FIPS

dea7785

Handle Semeru

ebaadc1

Merging Ut's code

0d67b38

add common crypto to ssl feature

1692ecf

Merge pull request OpenLiberty#4 from utle/FIPSwork

d15c6d4

add common crypto to ssl feature

enable openJCEPlusFips

ed707fa

clean up

6186795

Merge pull request OpenLiberty#5 from utle/FIPSwork

11f08a2

Fip swork

enable openJCEPlusFips

3bc4615

Merge remote-tracking branch 'ut_branch/FIPSwork' into FIPSwork

3bcc438

Merge branch 'OpenLiberty:integration' into FIPSwork

a1994c1

jimmy1wu and others added 17 commits January 7, 2025 13:20

Merge remote-tracking branch 'origin/release' into FIPSwork_01072025

3221f8e

Handle FIPS 140-2 and 140-3 separated to keep the current behavior

4689e3d

Merge remote-tracking branch 'ut_fork/FIPSwork' into FIPSwork_01072025

58df82d

Fixed FIPS140-2 enabled

d39aee3

remove duplicate ltpa config in nonFIPS case

9fa333d

comment out common.crypto trace

e3eb7a1

Removed these packages from the testpath

5ed9161

Remove un-use code

6f4fdd6

Fixed review comments

07f02f9

add the crypto bundle to the testpath

75006f1

use key to generate iv for gcm

4a299f2

Code review comments

6721ada

Remove the provider to keep previous code the same

3b9a76d

More code review comments

ca8a0cb

Comments un-needed code for FIPS

29acaf1

Update the SSL package version

56e4a61

Revert change for non-FIP cipher

cb316f0

testing

be10264

dmuelle added the ID reviewed label Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pkg test #30586

Pkg test #30586

utle commented Jan 18, 2025

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 18, 2025

LibbyBot commented Jan 18, 2025

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading

LibbyBot commented Jan 18, 2025

LibbyBot commented Jan 18, 2025

LibbyBot commented Jan 18, 2025

LibbyBot commented Jan 18, 2025

dmuelle commented Jan 21, 2025

utle commented Jan 22, 2025

Pkg test #30586

Are you sure you want to change the base?

Pkg test #30586

Conversation

utle commented Jan 18, 2025

Delete this section and fill in the remaining info from the template

utle commented Jan 18, 2025 • edited by LibbyBot Loading

utle commented Jan 18, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 18, 2025

Code analysis and actions

LibbyBot commented Jan 18, 2025

utle commented Jan 18, 2025 • edited by LibbyBot Loading

LibbyBot commented Jan 18, 2025

Code analysis and actions

LibbyBot commented Jan 18, 2025

LibbyBot commented Jan 18, 2025

Code analysis and actions

LibbyBot commented Jan 18, 2025

dmuelle commented Jan 21, 2025

utle commented Jan 22, 2025

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading

utle commented Jan 18, 2025 •

edited by LibbyBot

Loading