-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue Fix for build break Defect 303094 #30570
Issue Fix for build break Defect 303094 #30570
Conversation
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
...king/fat/src/com/ibm/ws/concurrent/persistent/fat/locking/PXLockTestWithFailoverEnabled.java
Outdated
Show resolved
Hide resolved
...king/fat/src/com/ibm/ws/concurrent/persistent/fat/locking/PXLockTestWithFailoverEnabled.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increasing the transaction timeout
The changes within this PR do not increase the transaction timeout, nor do they increase the missedTaskThreshold
as Tracy points out.
The team owning this bucket needs to spend time to understand what the test is doing, perform investigation of the failure, and write up a description of the problem in the issue or PR as they understand and how they are expecting to solve it. It is not the place of the code reviewer to do that work instead. That would be backwards. The only work I see here documenting any investigation or analysis is all from Brian before transferring this defect over, and from Tracy in attempting to review it.
You can use the information they have kindly provided, but you need to perform your own analysis taking that into account and be able to explain and justify whatever change you are making.
5ebb3a5
to
fde0b4a
Compare
#build Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_cBq0sN6QEe-M5OZShUU9WA The build will run your changed FAT bucket(s) 10 times. Target locations of links might be accessible only to IBM employees. |
release bug
label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Increasing the transaction timeout