New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JAX-WS: JAXB: backup with parent namespace test #30566

Merged

BerksanAtes merged 3 commits into OpenLiberty:integration from BerksanAtes:JAXB_BackupWithParentNamespace_Test

Jan 28, 2025

Member

BerksanAtes commented Jan 15, 2025

I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

JAXB provides com.sun.xml.bind.backupWithParentNamespace property to support old JAXB behavior. Tests are added to check the behavior.


          WIP test app created, test structure established

854ae75

BerksanAtes added in:Web Services team:Bobcats labels

BerksanAtes self-assigned this

Member Author

BerksanAtes commented Jan 15, 2025 •

edited by LibbyBot

Loading

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

BerksanAtes force-pushed the JAXB_BackupWithParentNamespace_Test branch from d3274f0 to 85b860f Compare

January 15, 2025 22:23

LibbyBot commented Jan 15, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

11 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
Please describe in a separate comment how you tested your changes.

LibbyBot added the noproductcode label

BerksanAtes force-pushed the JAXB_BackupWithParentNamespace_Test branch from 85b860f to 0df5832 Compare

January 15, 2025 22:25


          JAXB Legacy behavior support test is added

33ed703

BerksanAtes force-pushed the JAXB_BackupWithParentNamespace_Test branch from 0df5832 to 33ed703 Compare

January 15, 2025 22:27

Member Author

BerksanAtes commented Jan 16, 2025 •

edited by LibbyBot

Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot commented Jan 16, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

11 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
Please describe in a separate comment how you tested your changes.

neuwerk requested changes

View reviewed changes

Member

neuwerk left a comment

Changes look ok other then Copyrights. Also, do you need this empty file?

dev/com.ibm.ws.jaxb_fat/publish/servers/jaxbspec_fat/jvm.options

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/LibertyJAXBSpecTest.java Outdated

		@@ -0,0 +1,134 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

dev/com.ibm.ws.jaxb_fat/test-applications/jaxbApp/src/jaxb/xmlnsform/qualified/Person.java Outdated

		@@ -0,0 +1,50 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

...com.ibm.ws.jaxb_fat/test-applications/jaxbApp/src/jaxb/xmlnsform/qualified/package-info.java Outdated

		@@ -0,0 +1,15 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

...bm.ws.jaxb_fat/test-applications/jaxbApp/src/jaxb/xmlnsform/servlet/JaxbSpecTestServlet.java Outdated

		@@ -0,0 +1,83 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

dev/com.ibm.ws.jaxb_fat/test-applications/jaxbApp/src/jaxb/xmlnsform/unqualified/Person.java Outdated

		@@ -0,0 +1,50 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

...m.ibm.ws.jaxb_fat/test-applications/jaxbApp/src/jaxb/xmlnsform/unqualified/package-info.java Outdated

		@@ -0,0 +1,15 @@
		/*******************************************************************************
		* Copyright (c) 2024 IBM Corporation and others.

Member

neuwerk Jan 27, 2025

Suggested change

      
             * Copyright (c) 2024 IBM Corporation and others.
          
             * Copyright (c) 2025 IBM Corporation and others.

dev/com.ibm.ws.jaxb_fat/fat/src/com/ibm/ws/jaxb/fat/FATSuite.java

@@ @@ -24,6 +24,7 @@ @@
               @RunWith(Suite.class)
               @SuiteClasses({
                               LibertyJAXBTest.class,
+                              LibertyJAXBSpecTest.class,

Member

neuwerk Jan 27, 2025

Copyright needs to be

2019, 2025


          Copyright changes

f02402f

BerksanAtes force-pushed the JAXB_BackupWithParentNamespace_Test branch from 30d3dc5 to f02402f Compare

January 27, 2025 16:23

neuwerk approved these changes

View reviewed changes

Member

neuwerk commented Jan 27, 2025 •

edited by LibbyBot

Loading

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

LibbyBot commented Jan 27, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.

10 FAT files were changed, added, or removed.
Check that the build did not break the affected FAT suite(s).
Please describe in a separate comment how you tested your changes.

LibbyBot commented Jan 27, 2025

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_syK9YNzjEe-M5OZShUU9WA

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

BerksanAtes merged commit 4f3fefe into OpenLiberty:integration

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:Web Services noproductcode team:Bobcats