-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the Unused method TextEditConverter.convertToTextDocumentEdit(int) #1228
base: main
Are you sure you want to change the base?
Conversation
@mrglavas This is the LSP4MP4IJ codebase. Should we open an issue in the IntelliJ Quarkus repository to request these modifications in their repo, as it involves removal rather than a replacement for the deprecation? |
@anusreelakshmi934 Have you checked whether IntelliJ Quarkus is also not using this method? It would be ideal if we contributed a solution to IntelliJ Quarkus in a PR, but it should be appropriate for their project. Your statement that we are not using the method does not necessarily mean that they are not either. |
Hi @mrglavas . I reviewed the Quarks repository and discovered that this method is not being used there either. So, I have opened a PR in the IntelliJ-Quarkus repository as well. |
Created an Issue and Opened a PR in IntelliJ Quarkus - redhat-developer/intellij-quarkus#1426 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fixes #1187
The method convertToTextDocumentEdit(int) has 0 usages in our code . Hence removed the method and made the necessary refactoring