Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Unused method TextEditConverter.convertToTextDocumentEdit(int) #1228

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #1187
The method convertToTextDocumentEdit(int) has 0 usages in our code . Hence removed the method and made the necessary refactoring

@anusreelakshmi934
Copy link
Contributor Author

@mrglavas This is the LSP4MP4IJ codebase. Should we open an issue in the IntelliJ Quarkus repository to request these modifications in their repo, as it involves removal rather than a replacement for the deprecation?

@mrglavas
Copy link
Contributor

mrglavas commented Jan 17, 2025

@mrglavas This is the LSP4MP4IJ codebase. Should we open an issue in the IntelliJ Quarkus repository to request these modifications in their repo, as it involves removal rather than a replacement for the deprecation?

@anusreelakshmi934 Have you checked whether IntelliJ Quarkus is also not using this method? It would be ideal if we contributed a solution to IntelliJ Quarkus in a PR, but it should be appropriate for their project. Your statement that we are not using the method does not necessarily mean that they are not either.

@anusreelakshmi934
Copy link
Contributor Author

@mrglavas This is the LSP4MP4IJ codebase. Should we open an issue in the IntelliJ Quarkus repository to request these modifications in their repo, as it involves removal rather than a replacement for the deprecation?

@anusreelakshmi934 Have you checked whether IntelliJ Quarkus is also not using this method? It would be ideal if we contributed a solution to IntelliJ Quarkus in a PR, but it should be appropriate for their project. Your statement that we are not using the method does not necessarily mean that they are not either.

Hi @mrglavas . I reviewed the Quarks repository and discovered that this method is not being used there either. So, I have opened a PR in the IntelliJ-Quarkus repository as well.

@anusreelakshmi934
Copy link
Contributor Author

anusreelakshmi934 commented Jan 20, 2025

Created an Issue and Opened a PR in IntelliJ Quarkus - redhat-developer/intellij-quarkus#1426

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address usage of deprecated constructor 'VersionedTextDocumentIdentifier.<init>(Integer)'
3 participants