Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated constructor SymbolInformation changed to WorkspaceSymbol #1227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anusreelakshmi934
Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 commented Jan 14, 2025

Fixes #1186 #1182 #1181 #1180

The SymbolInformation Constructor is Changed to WorkspaceSymbol as per LSP4J documentation

Copy link
Contributor

@dessina-devasia dessina-devasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anusreelakshmi934 All the changes in this PR relate to classes in the lsp4mp4ij package, which have been copied from IntelliJ Quarkus. We should verify whether Red Hat has addressed the use of deprecated methods in their current code. If not, it may be worth contributing a PR to their repository. Since we periodically update lsp4mp4ij from IntelliJ Quarkus, maintaining alignment with the Red Hat version is crucial from a maintenance perspective. Each update carries the risk of losing changes made locally in Liberty Tools for IntelliJ.

@anusreelakshmi934
Copy link
Contributor Author

@anusreelakshmi934 All the changes in this PR relate to classes in the lsp4mp4ij package, which have been copied from IntelliJ Quarkus. We should verify whether Red Hat has addressed the use of deprecated methods in their current code. If not, it may be worth contributing a PR to their repository. Since we periodically update lsp4mp4ij from IntelliJ Quarkus, maintaining alignment with the Red Hat version is crucial from a maintenance perspective. Each update carries the risk of losing changes made locally in Liberty Tools for IntelliJ.

@dessina-devasia I checked the intellij quarks repo. They have not made the change. Its still the deprecated code. So Shall I go ahead and open a PR ?

@dessina-devasia
Copy link
Contributor

dessina-devasia commented Jan 14, 2025

I checked the intellij quarks repo. They have not made the change. Its still the deprecated code. So Shall I go ahead and open a PR ?

Sure @anusreelakshmi934. Please go ahead to open a PR in IntelliJ Quarkus

@anusreelakshmi934
Copy link
Contributor Author

Created an Issue and Opened a PR in IntelliJ Quarkus - redhat-developer/intellij-quarkus#1424

import org.eclipse.lsp4j.Range;
import org.eclipse.lsp4j.SymbolInformation;
import org.eclipse.lsp4j.SymbolKind;
import org.eclipse.lsp4j.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to import required class only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if the IDE made this change automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this import was automatically added by IntelliJ because more than three classes were being used in the code. As a result, it consolidated the imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants