Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issues with matching qualified names in AbstractDiagnosticsCollector #1111

Conversation

dessina-devasia
Copy link
Contributor

Fixes #1025

Refactored isMatchedAnnotation() and isMatchedJavaElement() to align the changes with fully qualified names

Copy link
Contributor

@anusreelakshmi934 anusreelakshmi934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

@dessina-devasia dessina-devasia merged commit 94f5dad into OpenLiberty:main Nov 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractDiagnosticsCollector: Investigate and resolve issues with matching qualified names.
3 participants