Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused unqualified names from WebSocketConstants #1056

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

anusreelakshmi934
Copy link
Contributor

Fixes #1031

@anusreelakshmi934 anusreelakshmi934 marked this pull request as draft October 29, 2024 09:57
@anusreelakshmi934 anusreelakshmi934 marked this pull request as ready for review October 29, 2024 10:37
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments.

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for following up and cleaning up the code.

@anusreelakshmi934 anusreelakshmi934 merged commit 001047d into OpenLiberty:main Nov 7, 2024
2 of 3 checks passed
@anusreelakshmi934 anusreelakshmi934 deleted the Issue#1031 branch December 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

websocket.WebSocketDiagnosticsCollector: Investigate and resolve issues with matching qualified names.
3 participants