Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain features.sh and configure.sh in Dockerfile #242

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

shin19991207
Copy link
Contributor

Addressed #179

Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID review

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
shin19991207 and others added 2 commits November 11, 2024 12:58
Co-authored-by: David Mueller <[email protected]>
Co-authored-by: David Mueller <[email protected]>
@shin19991207 shin19991207 requested a review from dmuelle November 11, 2024 18:01
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@gkwan-ibm gkwan-ibm merged commit 61c30f9 into staging Nov 12, 2024
5 checks passed
gkwan-ibm added a commit that referenced this pull request Nov 12, 2024
Merge staging to prod - Explain features.sh and configure.sh in Dockerfile (#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants