Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch user-set partial charges warning to log.info #468

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 23, 2025

Addresses #330

We decided to use logger.info, since it is encouraged for users to pre-set partial charges, and we shouldn't be yelling at them for that.

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@atravitz atravitz changed the title switch warning to log.info switch user-set partial charges warning to log.info Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (f8baf7f) to head (7c9e63d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          39       39           
  Lines        2166     2171    +5     
=======================================
+ Hits         2134     2139    +5     
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz self-assigned this Jan 23, 2025
@atravitz atravitz requested review from dotsdl and IAlibay January 23, 2025 20:44
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing otherwise lgtm

gufe/components/explicitmoleculecomponent.py Show resolved Hide resolved
@atravitz
Copy link
Contributor Author

pre-commit.ci autofix

Copy link
Member

@dotsdl dotsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one recommended change; otherwise it is good to merge!

gufe/components/explicitmoleculecomponent.py Outdated Show resolved Hide resolved
@atravitz atravitz enabled auto-merge (squash) January 24, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants