-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch user-set partial charges warning to log.info #468
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 39 39
Lines 2166 2171 +5
=======================================
+ Hits 2134 2139 +5
Misses 32 32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one thing otherwise lgtm
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one recommended change; otherwise it is good to merge!
Co-authored-by: David L. Dotson <[email protected]>
Addresses #330
We decided to use
logger.info
, since it is encouraged for users to pre-set partial charges, and we shouldn't be yelling at them for that.Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
news
entryDevelopers certificate of origin