kobotoolbox: implement generic name-spaced http methods #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
josephjclark
reviewed
Feb 3, 2025
| username: 'test', | ||
| password: 'strongpassword', | ||
| apiVersion: 'v2', | ||
| baseURL: 'https://test.kobotoolbox.org', |
There was a problem hiding this comment.
Oh, interesting that this is baseURL and not baseUrl. This comment is a reminder to me to maybe change this
| @@ -130,7 +202,7 @@ describe('getSubmissions', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('getForms', () => { | |||
| describe.skip('getForms', () => { | |||
There was a problem hiding this comment.
Yep, it's Ok to skip these for now, we'll come in and re-write them a bit later. We need to remember to remove nock from this adaptor. Maybe we should do it in this PR?
Signed-off-by: Hunter Achieng <[email protected]>
josephjclark
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Looks good to me @hunterachieng I'll sleep on the other questions I've raised and decide whether we want to do something now or later. But you can move on form here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement generic name-spaced http helpers:
get,postandputFixes #934
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.