Adding support for file-based reads and externalized type dependencies #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is non-breaking change that adds a new public method: read_files - a file-oriented entry point to the front end. This takes a list of target DSDL files allowing the user to maintain an explicit list instead of depending on globular filesystem discovery. Furthermore this method returns a set which is the transitive closure of types depended on by the target list of types. This allows consumers to track dependencies and compiler back ends to generate .d files and otherwise support incremental builds. The new method may increase performance for systems with large pools of messages when generating code for a small sub-set as it only considers the target and dependencies of the target when parsing dsdl files.
|
ping? Any chance I can get a review on this? |
|
@thirtytwobits Sorry, I will do it today/tomorrow |
pavel-kirienko
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Please see the comments to #101.
Suppose I invoke read_files with a root namespace foo and a DSDL definition named foo.foo.Bar.1.0; is this going to work? What about foo.baz.foo.Bar.1.0?
Co-authored-by: Pavel Kirienko <[email protected]>
Co-authored-by: Pavel Kirienko <[email protected]>
|
But there's a future import for that
…On Thu, Jun 20, 2024, 01:14 Scott Dixon ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In noxfile.py
<#103 (comment)>:
> - "--strict",
- f"--config-file={ROOT_DIR / 'setup.cfg'}",
- "pydsdl",
- env={
- "MYPYPATH": str(THIRD_PARTY_DIR),
- },
- )
- session.run(
- "pylint",
- str(ROOT_DIR / "pydsdl"),
- env={
- "PYTHONPATH": str(THIRD_PARTY_DIR),
- },
- )
+ if is_oldest_python(session):
+ # we run mypy and pylint only on the oldest Python version to ensure maximum compatibility
But then it won't be compatible with 3.8.
—
Reply to this email directly, view it on GitHub
<#103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFIZAWRDF3TUYINF7ZS53ZIH7GDAVCNFSM6AAAAABILVRJOSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRZGA4TCNZTGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Co-authored-by: Pavel Kirienko <[email protected]>
|
Okay. Just the |
|
I tried pushing this but it says your diff --git a/noxfile.py b/noxfile.py
index f9e73d2..61a409b 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -122,6 +122,3 @@ def docs(session):
def is_latest_python(session) -> bool:
return PYTHONS[-1] in session.run("python", "-V", silent=True)
-
-def is_oldest_python(session) -> bool:
- return PYTHONS[0] in session.run("python", "-V", silent=True) |
This change is already in my PR. |
|
I believe all issues are addressed now? |
|
I fixed the CI build errors on my end. Everything is ready to go. |
…Cyphal/pydsdl/pull/101\#discussion_r1590898374 and replace a few deprecated typing entities with modern alternatives
pavel-kirienko
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is non-breaking change that adds a new public method:
read_files - a file-oriented entry point to the front end. This takes a list of target DSDL files allowing the user to maintain an explicit list instead of depending on globular filesystem discovery. Furthermore this method returns a set which is the transitive closure of types depended on by the target list of types. This allows consumers to track dependencies and compiler back ends to generate .d files and otherwise support incremental builds.
The new method may increase performance for systems with large pools of messages when generating code for a small sub-set as it only considers the target and dependencies of the target when parsing dsdl files.