Skip to content

Commit

Permalink
Fix CI
Browse files Browse the repository at this point in the history
  • Loading branch information
pavel-kirienko committed Mar 4, 2024
1 parent 1f3233e commit 742df05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cetlvast.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
toolchain: [gcc, clang]
include:
- build_flavor: Coverage
exceptions: no-exceptions
exceptions: exceptions
std: 14
toolchain: gcc
exclude:
Expand Down
4 changes: 3 additions & 1 deletion include/cetl/pf17/variant.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,9 @@ struct is_viable_alternative_conversion<
To,
// The number of braces is of an essential importance here: {{ }} creates a temporary before invoking the
// move ctor, while {{{ }}} constructs the object in place. Incorrect usage of the braces will cause
// incorrect detection of the applicable conversion.
// incorrect detection of the applicable conversion, which is the case in the GNU libstdc++ implementation.
// Notice that there is a subtle difference between C++14 and the newer standards with the guaranteed copy
// elision: a double-brace conversion is invalid in C++14 for noncopyable types while in C++17+ it is valid.
// An alternative way to test the conversion is to define a function that accepts an array rvalue:
// static void test_conversion(To (&&)[1]);
// And check if it is invocable with the argument of type From.
Expand Down

0 comments on commit 742df05

Please sign in to comment.