Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPSum ] Add connector #3002

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

baptiste-fourmont
Copy link
Contributor

@baptiste-fourmont baptiste-fourmont commented Nov 20, 2024

Proposed changes

  • [Add] IPsum connector: https://github.com/stamparm/ipsum/tree/master
    IPsum is a threat intelligence feed based on 30+ different publicly available lists of suspicious and/or malicious IP addresses. All lists are automatically retrieved and parsed on a daily (24h) basis and the final result is pushed to this repository. By default, I have choose the list "5" because it contains ultra false positives

I have used the new connector template to do this

Related issues

  • No one

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the community use to identify PR from community label Dec 5, 2024
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and the work you've put into this! I’ve reviewed the pull request, and here are a few suggestions for improvement to ensure the project remains consistent and clear:

  • Update the README file with the correct variable names for better clarity.
  • Remove any unnecessary comments from the code to keep it clean and focused.
  • Add this project to CircleCI for continuous integration and deployment pipeline file.

Let me know if you need any assistance with these changes. Thanks again for your efforts!

@baptiste-fourmont
Copy link
Contributor Author

Hello Flavien,

I have made the modfication according to your feedback :)
@flavienSindou

Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @baptiste-fourmont

@flavienSindou flavienSindou self-requested a review January 8, 2025 09:52
Copy link
Contributor

@flavienSindou flavienSindou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @baptiste-fourmont, I wasn’t able to merge your Pull Request quickly enough, and a merge conflict has appeared.

Could you please resolve it or add me as a project contributor so I can take care of it?

@flavienSindou flavienSindou linked an issue Jan 8, 2025 that may be closed by this pull request
@flavienSindou flavienSindou changed the title [Add] IPSum connector [IPSum ] Add connector Jan 8, 2025
@baptiste-fourmont
Copy link
Contributor Author

Hello For personal reasons I can't do it this week. I added you as a contributor. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IPSUM] - Create Connector
3 participants