-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IPSum ] Add connector #3002
base: master
Are you sure you want to change the base?
[IPSum ] Add connector #3002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution and the work you've put into this! I’ve reviewed the pull request, and here are a few suggestions for improvement to ensure the project remains consistent and clear:
- Update the README file with the correct variable names for better clarity.
- Remove any unnecessary comments from the code to keep it clean and focused.
- Add this project to CircleCI for continuous integration and deployment pipeline file.
Let me know if you need any assistance with these changes. Thanks again for your efforts!
Hello Flavien, I have made the modfication according to your feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @baptiste-fourmont
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @baptiste-fourmont, I wasn’t able to merge your Pull Request quickly enough, and a merge conflict has appeared.
Could you please resolve it or add me as a project contributor so I can take care of it?
Hello For personal reasons I can't do it this week. I added you as a contributor. Thank you |
Proposed changes
IPsum is a threat intelligence feed based on 30+ different publicly available lists of suspicious and/or malicious IP addresses. All lists are automatically retrieved and parsed on a daily (24h) basis and the final result is pushed to this repository. By default, I have choose the list "5" because it contains ultra false positives
I have used the new connector template to do this
Related issues
Checklist
Further comments