Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1981, exporter match rocksdb metrics error #2083

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

machinly
Copy link
Collaborator

此 PR 修复了 rocksdb 选项为 false 时,exporter 尝试但拿不到 rocksdb 的信息,导致的匹配失败的问题。

使用手动控制是否注册,来避免错误

related issue: #1981

@machinly machinly changed the title fix: 1981, exporter match rocksdb fix: 1981, exporter match rocksdb metrics error Oct 27, 2023
Copy link
Collaborator

@chenbt-hz chenbt-hz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit d796dd7 into OpenAtomFoundation:unstable Oct 30, 2023
13 checks passed
@machinly machinly deleted the fix_1981 branch April 20, 2024 12:27
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants