-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remoteproc_virtio: add shm_io for remoteproc virtio #542
base: main
Are you sure you want to change the base?
Conversation
Now the rpmsg device need pass a share memory io region to rpmsg_init_vdev(). I think every virtio device need a share memory io to access the share memory and this region should be provided by the transport layer. Like the MMIO transport layer did in OpenAMP. So I add shm_io in the remoteproc virtio device and also provide a API to set it. Signed-off-by: Bowen Wang <[email protected]>
Any usage of this API anywhere ? Either in demos or OpenAMP ? @arnopo, @edmooring any thoughts? |
Quite agree with @tnmysh. This PR introduces an unused field. If possible I would prefer it to be integrated in a PR that provides the full picture of the need. @tnmysh : I remember we discussed the possibility of using dmabuf-based memory allocation in a meeting, but I don't see any associated PR or issue. Could you please provide a reference if you have it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any consumers for this new API? I can't find any in either open-amp or openamp-system-reference.
@arnopo @tnmysh @edmooring Thanks, I use this API in NuttX (but code not up streamed). We want make the remoteproc transport layer supports more virtio devices. |
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
@tnmysh I want to continue this PR and I'm interested in the dma method. That will be very thankfully if you can proviud a reference if you have it. |
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
don't need anymore? @CV-Bowen |
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
Now the rpmsg device need pass a share memory io region to rpmsg_init_vdev().
I think every virtio device need a share memory io to access the share memory and this region should be provided by the transport layer. Like the MMIO transport layer did in OpenAMP.
So I add shm_io in the remoteproc virtio device and also provide an API to set it.