Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: add initial support virtio mmio net, rng and serial frontend drivers #529

Closed
wants to merge 1 commit into from

Conversation

uLipe
Copy link
Collaborator

@uLipe uLipe commented Oct 26, 2023

This PR brings the work already done in the open-amp/virtio-exp branch and targets them to the upstream, it is composed by the implementations of the front end drivers of Serial, Networking and RNG kind of devices under the native virtio-mmio transport, for example using the device side implemented into QEMU. It is on top of the work did by @danmilea with some changes to reflect the recent updates on the open-amp functions.

Although the implementations of the devices above are complete, there are some decisions regarding the placement of the VRINGS and how to expose them for both sides needs to be taken, and until that this PR can be reviewed but it should not merged.

The current drivers were tested against following Zephyr RTOS branch,
which provided some samples to evaluate each of the devices:

@uLipe uLipe marked this pull request as draft October 26, 2023 13:38
@uLipe
Copy link
Collaborator Author

uLipe commented Oct 26, 2023

@arnopo @danmilea @wmamills

Just for following-up until we decide what is the solution to solve the question of the VRINGS placement.

@wmamills
Copy link
Collaborator

wmamills commented Nov 1, 2023

@uLipe please add Dan to the commit header. For now it can be in the form of "
Code authored by Dan Milea [email protected]

We can fix it up when Dan signs off

rng, net and serial device frontend.

Authored-by: Dan Milea [email protected]

Signed-off-by: Felipe Neves <[email protected]>
@uLipe uLipe force-pushed the feature/virtio_mmio_drivers_native branch from 5ec99e2 to 1a94260 Compare November 1, 2023 22:16
@uLipe
Copy link
Collaborator Author

uLipe commented Nov 1, 2023

@uLipe please add Dan to the commit header. For now it can be in the form of " Code authored by Dan Milea [email protected]

We can fix it up when Dan signs off

Done!

@arnopo
Copy link
Collaborator

arnopo commented Nov 2, 2023

@uLipe or @danmilea,
Please split the commit into one commit per service. This will help with the review and maintenance process

@danmilea
Copy link
Collaborator

danmilea commented Nov 2, 2023

@arnopo I don't think the purpose of this PR was to get merged in open-amp main, but to replace the virtio-exp branch. In order to do that, a tag should be created on the current HEAD of virtio-exp, then virtio-exp should be replaced/recreated based on the main branch. Once that is done (I assume by you?), we can reintroduce the native virtio functionality using PRs.

@uLipe
Copy link
Collaborator Author

uLipe commented Nov 8, 2023

As we discussed in the development channel, @danmilea already have the additions of virtio-mmio drivers in place, but in another branch that will be upstreamed to the main branch once it gets done, so I'm closing this one.

Please feel free to reopen if something changes.

@uLipe uLipe closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants