Install vcrun2022 for all Epic titles by default #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only verb that's not provided with games usually. As games assume EGS will install that. This is not the case for tools based on legendary, so this is why we had vcrun2022 for every problematic title. I believe we should add it for every possible game, there are no downsides to this.
This PR also removes some obsolete fixes like
CYGNI: All Guns Blazing- the parameter is handled by legendary itself nowBorderlands 3's vcrun2019 install - the verb will be handled by EGS vcrun2022 and Steam version provides necessary dependencies via its install scripts