Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Middle-earth: Shadow of War (GOG/Steam) #213

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

BlueInterlude
Copy link
Contributor

Updated to vcrun2022.

I seem to be getting the following error when using vcrun2019:

Executing cd /home/deck/.cache/winetricks/vcrun2019
Executing /home/deck/.config/heroic/tools/proton/Proton-GE-Proton9-23/files/bin/wine vc_redist.x86.exe /q
fsync: up and running.
------------------------------------------------------
warning: Note: command /home/deck/.config/heroic/tools/proton/Proton-GE-Proton9-23/files/bin/wine vc_redist.x86.exe /q returned status 102. Aborting.
------------------------------------------------------
�[33mProtonFixes[36985] WARN: Winetricks failed running verb "vcrun2019" with status 1.�[0m
Proton: /home/deck/Games/Heroic/Shadow of War/x64/ShadowOfWar.exe
Proton: Executable a unix path, launching with /unix option.
fsync: up and running.
Command exited with status: 0
Launch command: ['/home/deck/.config/heroic/tools/runtimes/umu/umu_run.py', '/home/deck/Games/Heroic/Shadow of War/x64/ShadowOfWar.exe']
All processes exited
============= End of log =============

No issues when using vcrun2022. Not sure if this is a separate issue altogether though.

Updated to vcrun2022.

I seem to be getting the following error when using vcrun2019:

```
Executing cd /home/deck/.cache/winetricks/vcrun2019
Executing /home/deck/.config/heroic/tools/proton/Proton-GE-Proton9-23/files/bin/wine vc_redist.x86.exe /q
fsync: up and running.
------------------------------------------------------
warning: Note: command /home/deck/.config/heroic/tools/proton/Proton-GE-Proton9-23/files/bin/wine vc_redist.x86.exe /q returned status 102. Aborting.
------------------------------------------------------
�[33mProtonFixes[36985] WARN: Winetricks failed running verb "vcrun2019" with status 1.�[0m
Proton: /home/deck/Games/Heroic/Shadow of War/x64/ShadowOfWar.exe
Proton: Executable a unix path, launching with /unix option.
fsync: up and running.
Command exited with status: 0
Launch command: ['/home/deck/.config/heroic/tools/runtimes/umu/umu_run.py', '/home/deck/Games/Heroic/Shadow of War/x64/ShadowOfWar.exe']
All processes exited
============= End of log =============
```

No issues when using vcrun2022. Not sure if this is a separate issue altogether though.
@R1kaB3rN
Copy link
Member

R1kaB3rN commented Jan 19, 2025

I don't own this title, but if we're to trust the recent user reports from ProtonDB then this fix is no longer needed for the Steam version. Instead, we can make it GOG-specific.

We can merge this for now, but I will say that HGL just recently fixed a bug in its game installation process that had, in some cases, failed installing the game's dependencies when umu is enabled. So this fix will need to be reevaluated later on.

gamefixes-steam/356190.py Outdated Show resolved Hide resolved
@R1kaB3rN R1kaB3rN merged commit 0cae93d into Open-Wine-Components:master Jan 19, 2025
2 checks passed
@BlueInterlude BlueInterlude deleted the patch-1 branch January 19, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants