-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmission expansion #38
Conversation
nick-gorman
commented
Jan 31, 2025
- add table with manual extracted transmission costs
- merge costs into flow_paths.csv in template
- add costs in translator and set s_nom_extendable when cost is not NA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems solid to me here too! And even answered some of my questions on the other PR I think :)
) | ||
|
||
lines["s_nom_extendable"] = expansion_on | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm confusing myself a bit here but wondering why in lines.py the s_nom_extendable
field is False unless capital_cost
is not nan, but here isn't conditional on costs? I'm not 100% across all the network stuff so apologies if this is obvious!!
lines["s_nom_extendable"] = False | ||
# If a non-nan capital_cost is given then set to extendable | ||
lines.loc[~lines["capital_cost"].isna(), "s_nom_extendable"] = expansion_on | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess specifically it's only set to extendable if expansion_on
is also True? Probably too pedantic but noting for my own clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it is inconsistent between the two functions, I hadn't intended that, and probably best to fix.
In fact, very good to fix because it turns out PyPSA parses a nan capital cost to zero, rather than not allowing expansion because the cost is undefied!
So I'll update translate_renewable_energy_zone_build_limits_to_flow_paths to only set s_nom_extendable to True when the capital cost is non-nan. That way, users can turn expansion off for an individual rez by setting the capital cost to nan.
I made the s_nom_extendable change on the wrong PR, but planning to merge this PR into #37 anyway. |
814c906
to
2e57eed
Compare
for more information, see https://pre-commit.ci
I ended up rebasing this branch of rez_build_limits, so merging this branch into the main will bring combined changes. |