Have search boxes update on right-click paste #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| trimmed_search_term.length > 2 || | ||
| ((trimmed_search_term.length > 1) && !should_delay) | ||
| ) { | ||
| // never search for a single character |
There was a problem hiding this comment.
Move this comment up before the if condition for readability.
| @@ -100,45 +100,63 @@ | |||
| </div> | |||
| <script> | |||
| (function() { | |||
| const update_search = (search_element, should_delay, debug_label) => { | |||
There was a problem hiding this comment.
This looks intentionally identical to the code in the other layout file. Please add a comment to each noting that these should stay in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933
Previously. Only keyboard events were triggering search updates, so lots of ways of changing the text (including copy-paste on iPad) didn't trigger it.
Little refactor too so we even save 6 lines of code 😉