Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that after deleting any task from the wbs task list it should not show blank screen. #3104

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ShraddhaShahari
Copy link

Description

This PR addresses the issue that caused the screen to go blank after editing or deleting a task from the WBS tasks list. The issue was due to missing checks for undefined task categories, which caused the UI to break. Now, the task list updates correctly without needing a page refresh

Related PRS (if any):

None

Main changes explained:

  1. It first checks if task exists before trying to access task.category, to prevent runtime errors when no matching task is found.
  2. Ensures project exists before accessing its properties, it will avoid crashes when find returns undefined.
  3. If neither task nor project exists or has a category, it will safely defaults to 'Unspecified' instead of causing an error.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Other Links→ projects→select WBS icon for project you want to test-> Select WBS name->Edit it and try to remove/ edit any task under WBS
  6. verify if after deleting/ editing task it should be quickly deleted from task list and it should not show blank page.
  7. verify this feature works in [dark mode]
    (Verify this for both Admin and Owner user role)

Screenshots or videos of changes:

Before fix:

Before-blank.screen.mov

After fix:

after-bug-fixing.mov

Note:

you will need to have a project with wbs and tasks created under it, before testing this flow.

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit a63eb75
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/679d6ec140d8ad0008a92405
😎 Deploy Preview https://deploy-preview-3104--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShraddhaShahari ShraddhaShahari force-pushed the shraddha-blank-screen-after-task-deletion branch from 9f0907e to a63eb75 Compare February 1, 2025 00:45
Copy link
Contributor

@anirudhsk2107 anirudhsk2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working as expected
Screenshot 2025-02-01 110028

Screenshot 2025-02-01 110113

Copy link

@fangedShadow fangedShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the task is deleting properly and not sending a blank screen

Screen.Recording.2025-02-01.121729.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants